Fix more tests

remix-run · Oct 29, 2024 · e122aab · e122aab
1 parent 29ebf0e
commit e122aab
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 4 deletions.
diff --git a/integration/client-data-test.ts b/integration/client-data-test.ts
@@ -940,9 +940,10 @@ test.describe("Client Data", () => {
       page.on("console", (msg) => {
         let text = msg.text();
         if (
+          text.includes("React Router Future Flag Warning") ||
           // Ignore any dev tools messages. This may only happen locally when dev
           // tools is installed and not in CI but either way we don't care
-          /Download the React DevTools/.test(text)
+          text.includes("Download the React DevTools")
         ) {
           return;
         }

diff --git a/integration/prefetch-test.ts b/integration/prefetch-test.ts
@@ -791,7 +791,9 @@ test.describe("single fetch", () => {
 
       let consoleLogs: string[] = [];
       page.on("console", (msg) => {
-        consoleLogs.push(msg.text());
+        if (!msg.text().includes("React Router Future Flag Warning")) {
+          consoleLogs.push(msg.text());
+        }
       });
 
       let selectors = {

diff --git a/integration/resource-routes-test.ts b/integration/resource-routes-test.ts
@@ -247,7 +247,11 @@ test.describe("loader in an app", async () => {
     page,
   }) => {
     let logs: string[] = [];
-    page.on("console", (msg) => logs.push(msg.text()));
+    page.on("console", (msg) => {
+      if (!msg.text().includes("React Router Future Flag Warning")) {
+        logs.push(msg.text());
+      }
+    });
     let app = new PlaywrightFixture(appFixture, page);
     await app.goto("/");
     await app.clickSubmitButton("/no-action");

diff --git a/integration/vite-spa-mode-test.ts b/integration/vite-spa-mode-test.ts
@@ -504,7 +504,11 @@ test.describe("SPA Mode", () => {
       expect(html).toMatch('<h1 data-loading="true">Loading SPA...</h1>');
 
       let logs: string[] = [];
-      page.on("console", (msg) => logs.push(msg.text()));
+      page.on("console", (msg) => {
+        if (!msg.text().includes("React Router Future Flag Warning")) {
+          logs.push(msg.text());
+        }
+      });
 
       let app = new PlaywrightFixture(appFixture, page);
       await app.goto("/");