Don't pass --node-modules-dir flag to deno install

remix-run · Sep 2, 2024 · b94e223 · b94e223
1 parent 1e48a52
commit b94e223
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/packages/create-remix/__tests__/create-remix-test.ts b/packages/create-remix/__tests__/create-remix-test.ts
@@ -926,11 +926,7 @@ describe("create-remix CLI", () => {
 
     expect(execa).toHaveBeenCalledWith(
       "deno",
-      expect.arrayContaining([
-        "install",
-        "--node-modules-dir=true",
-        "--no-lock",
-      ]),
+      expect.arrayContaining(["install", "--no-lock"]),
       expect.objectContaining({ env: { DENO_FUTURE: "1" } })
     );
     delete process.versions.deno;

diff --git a/packages/create-remix/__tests__/fixtures/successful-remix-init-deno/deno.json b/packages/create-remix/__tests__/fixtures/successful-remix-init-deno/deno.json
@@ -1,4 +1,5 @@
 {
+  "nodeModulesDir": true,
   "imports": {
     "is-odd": "npm:[email protected]"
   }

diff --git a/packages/create-remix/index.ts b/packages/create-remix/index.ts
@@ -672,12 +672,7 @@ async function installDependencies({
   try {
     await execa(
       pkgManager,
-      [
-        "install",
-        ...(pkgManager === "deno"
-          ? ["--node-modules-dir=true", "--no-lock"]
-          : []),
-      ],
+      ["install", ...(pkgManager === "deno" ? ["--no-lock"] : [])],
       {
         cwd,
         env: pkgManager === "deno" ? { DENO_FUTURE: "1" } : undefined,