Skip to content

Commit

Permalink
explict variable naming
Browse files Browse the repository at this point in the history
  • Loading branch information
pcattori committed Aug 29, 2024
1 parent 2114357 commit 1b3d1db
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/remix-dev/vite/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1075,8 +1075,8 @@ export const remixVitePlugin: RemixVitePlugin = (remixUserConfig = {}) => {
: undefined,
},
optimizeDeps: {
entries: Object.values(ctx.remixConfig.routes).map((r) =>
path.join(ctx.remixConfig.appDirectory, r.file)
entries: Object.values(ctx.remixConfig.routes).map((route) =>
path.join(ctx.remixConfig.appDirectory, route.file)
),
include: [
// Pre-bundle React dependencies to avoid React duplicates,
Expand Down
14 changes: 14 additions & 0 deletions plan.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
- [ ] add `turbo-stream` encode post-plugin and decode plugin for unserializable -> `undefined`
- [ ] interface merge for single-fetch types
- [ ] docs

when `single-fetch` is disabled, everything behaves the same way as it does today
when `single-fetch` is enabled, `defer` is no longer a concept, but `json` still is! also `data` exists now too.

so we need a `SerializeFrom` function for `single-fetch` that handles:

- bare objects
- `json`
- `data`

that will handle all downstream APIs that depend on `typeof loader` or `typeof action` like `useLoaderData`, `serverLoader` prop for `clientLoader`, etc.

0 comments on commit 1b3d1db

Please sign in to comment.