Skip to content

chore: remove unused npm-run-all dependency #13718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Jun 1, 2025

This upgrades from npm-run-all to npm-run-all2. Primarily because the latter is actively maintained, has security updates and a reduced footprint in the dependency tree.

I'm sure people from the wider @e18e ecosystem cleanup (like @43081j) will be very happy to see these kind of changes as well

This package isn't used by any of the code, so it can be removed

@MichaelDeBoey MichaelDeBoey requested a review from brophdawg11 June 1, 2025 22:33
@MichaelDeBoey MichaelDeBoey added the dependencies Pull requests that update a dependency file label Jun 1, 2025
Copy link

changeset-bot bot commented Jun 1, 2025

⚠️ No Changeset found

Latest commit: cc9c0cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@outslept
Copy link

outslept commented Jun 1, 2025

Hey, I found that the npm-run-all dependency might be unnecessary:

  • Searching for "npm-run-all" returns 0 results in the codebase (except the actual package in package.json's dependency field)
  • The only mentions of "run-s" and "run-p" are in an old changelog (v1.16.0), where they were already removed in a diff:
  {
    // ...
    "scripts": {
  -    "build": "run-s \"build:*\"",
  +    "build": "remix build",
  -    "build:css": "npm run generate:css -- --minify",
  -    "build:remix": "remix build",
  -    "dev": "run-p \"dev:*\"",
  +    "dev": "remix dev",
  -    "dev:css": "npm run generate:css -- --watch",
  -    "dev:remix": "remix dev",
  -    "generate:css": "npx tailwindcss -o ./app/tailwind.css",
      "start": "remix-serve build"
    }
    // ...
  }

Can we safely remove this dependency since it's not being used anywhere?

Source (L1921 & L1925):

- "build": "run-s \"build:*\"",

@MichaelDeBoey MichaelDeBoey force-pushed the use-maintained-fork-of-npm-run-all branch from 3e7499f to 487a552 Compare June 2, 2025 02:11
@MichaelDeBoey MichaelDeBoey changed the title chore: use maintained fork of npm-run-all chore: remove npm-run-all usage Jun 2, 2025
@outslept

This comment was marked as off-topic.

@MichaelDeBoey

This comment was marked as off-topic.

@MichaelDeBoey MichaelDeBoey force-pushed the use-maintained-fork-of-npm-run-all branch from 487a552 to cc9c0cf Compare June 4, 2025 22:11
@markdalgleish markdalgleish changed the title chore: remove npm-run-all usage chore: remove unused npm-run-all dependency Jun 5, 2025
@markdalgleish markdalgleish merged commit 044ba5e into remix-run:dev Jun 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants