Fix Playwright hanging in Node 20.5.2+

remix-run · Apr 15, 2024 · 9e89ef2 · 9e89ef2
1 parent cf4ee0c
commit 9e89ef2
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 8 deletions.
diff --git a/.github/workflows/integration-full.yml b/.github/workflows/integration-full.yml
@@ -34,7 +34,7 @@ jobs:
     uses: ./.github/workflows/shared-integration.yml
     with:
       os: "ubuntu-latest"
-      node_version: '[18, "20.5.1"]'
+      node_version: "[18, 20]"
       browser: '["chromium", "firefox"]'
 
   integration-windows:
@@ -43,7 +43,7 @@ jobs:
     uses: ./.github/workflows/shared-integration.yml
     with:
       os: "windows-latest"
-      node_version: '[18, "20.5.1"]'
+      node_version: "[18, 20]"
       browser: '["msedge"]'
 
   integration-macos:
@@ -52,5 +52,5 @@ jobs:
     uses: ./.github/workflows/shared-integration.yml
     with:
       os: "macos-latest"
-      node_version: '[18, "20.5.1"]'
+      node_version: "[18, 20]"
       browser: '["webkit"]'
diff --git a/.github/workflows/integration-pr-ubuntu.yml b/.github/workflows/integration-pr-ubuntu.yml
@@ -31,5 +31,5 @@ jobs:
     uses: ./.github/workflows/shared-integration.yml
     with:
       os: "ubuntu-latest"
-      node_version: '["20.5.1"]'
+      node_version: "[20]"
       browser: '["chromium"]'
diff --git a/.github/workflows/integration-pr-windows-macos.yml b/.github/workflows/integration-pr-windows-macos.yml
@@ -19,7 +19,7 @@ jobs:
     uses: ./.github/workflows/shared-integration.yml
     with:
       os: "ubuntu-latest"
-      node_version: '["20.5.1"]'
+      node_version: "[20]"
       browser: '["firefox"]'
 
   integration-msedge:
@@ -28,7 +28,7 @@ jobs:
     uses: ./.github/workflows/shared-integration.yml
     with:
       os: "windows-latest"
-      node_version: '["20.5.1"]'
+      node_version: "[20]"
       browser: '["msedge"]'
 
   integration-webkit:
@@ -37,5 +37,5 @@ jobs:
     uses: ./.github/workflows/shared-integration.yml
     with:
       os: "macos-latest"
-      node_version: '["20.5.1"]'
+      node_version: "[20]"
       browser: '["webkit"]'
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-20.5.1
+20
diff --git a/integration/playwright.config.ts b/integration/playwright.config.ts
@@ -6,6 +6,11 @@ const config: PlaywrightTestConfig = {
   testMatch: ["**/*-test.ts"],
   // TODO: Temporary!  Remove from this list as we get each suite passing
   testIgnore: ["**/vite-cloudflare-test.ts"],
+  // Playwright treats our workspace packages as internal by default. If we
+  // don't mark them as external, tests hang in Node 20.5.2+
+  build: {
+    external: ["**/packages/**/*"],
+  },
   /* Maximum time one test can run for. */
   timeout: process.platform === "win32" ? 60_000 : 30_000,
   fullyParallel: true,