Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cookiecutter structure #2

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Update cookiecutter structure #2

merged 1 commit into from
Jul 29, 2020

Conversation

jpichon
Copy link
Contributor

@jpichon jpichon commented Jul 29, 2020 •
edited
Loading

Cookie cutter update

@jpichon
Copy link
Contributor Author

jpichon commented Jul 29, 2020

Ah! Looks like I missed the Travis tests in the cookie cutter update. This will fail because of Python 2 support removal. On it.

@jpichon jpichon force-pushed the update_structure branch from 5f14499 to 32fa80a Compare July 29, 2020 14:02
jguiditta
jguiditta reviewed Jul 29, 2020
View reviewed changes
Copy link
Member

@jguiditta jguiditta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could these commits be separate PRs? I have some thoughts on the structure of the code, but I don't want to hold up the whole patch to discuss, since the basic cookiecutter stuff looks fine, with the exception of the minor question below.

README.rst Outdated Show resolved Hide resolved
@jpichon
Copy link
Contributor Author

jpichon commented Jul 29, 2020

Could these commits be separate PRs? I have some thoughts on the structure of the code, but I don't want to hold up the whole patch to discuss, since the basic cookiecutter stuff looks fine, with the exception of the minor question below.

Did it that way (separate commits, one PR) because we can't do dependent PRs in Github. But I can resubmit this with just the cookie cutter update which should be straightforward, and once that's merged submit the rest. Sounds good, thanks for looking at this already!

@jpichon jpichon force-pushed the update_structure branch from 32fa80a to 2c4822e Compare July 29, 2020 14:40
@jpichon jpichon changed the title Update cookiecutter and set up an initial skeleton structure to work from Update cookiecutter structure Jul 29, 2020
jguiditta
jguiditta approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@jguiditta jguiditta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jguiditta
Copy link
Member

I guess we don't have mergify yet, I'll merge this now...

@jguiditta jguiditta merged commit 16df542 into release-depot:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jguiditta jguiditta jguiditta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpichon @jguiditta