Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1 - Broadcast - Slog wrapper #198

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

1 - Broadcast - Slog wrapper #198

wants to merge 2 commits into from

Conversation

aleksander-vedvik
Copy link
Collaborator

The broadcast code heavily relies on the logging wrapper. Hence, it is included first.

@aleksander-vedvik
feat(Logging): implemented a slog wrapper
aefe0af 
- The broadcast implementation greatly relies on the logging feature
- Type safety in logs is encouraged by the wrapper
@aleksander-vedvik aleksander-vedvik mentioned this pull request Jan 11, 2025
Open
@aleksander-vedvik aleksander-vedvik changed the title feat(Logging): implemented a slog wrapper 1 - Broadcast - Slog wrapper Jan 11, 2025
meling
meling approved these changes Jan 11, 2025
View reviewed changes
Copy link
Member

@meling meling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PRs :-)

BroadcastID and MachineID are the only "labels" with capitalization (first letter). Does this have a particular significance, or should it be lower-cased to match the other labels?

@aleksander-vedvik
Copy link
Collaborator Author

Thanks for the PRs :-)

BroadcastID and MachineID are the only "labels" with capitalization (first letter). Does this have a particular significance, or should it be lower-cased to match the other labels?

Nope, they can be lower-cased 👌

@deepsource-io deepsource.io
Copy link
Contributor

deepsource-io bot commented Jan 18, 2025 •
edited
Loading

Here's the code health analysis summary for commits b8287c2..b99652f. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗
DeepSource Shell LogoShell✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meling meling meling approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleksander-vedvik @meling