Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix goroutine leak when test with an empty node list #190

Merged
merged 1 commit into from
Oct 10, 2024
+4 −2
Merged

Fix goroutine leak when test with an empty node list #190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions channel_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,9 @@ func TestChannelCreation(t *testing.T) {
if err != nil {
t.Fatal(err)
}
//the node should be closed manually because it isn't added to the configuration
defer node.close()
mgr := dummyMgr()
defer mgr.Close()
// a proper connection should NOT be established here
node.connect(mgr)

Expand Down Expand Up @@ -117,8 +118,9 @@ func TestChannelReconnection(t *testing.T) {
if err != nil {
t.Fatal(err)
}
//the node should be closed manually because it isn't added to the configuration
defer node.close()
mgr := dummyMgr()
defer mgr.Close()
// a proper connection should NOT be established here because server is not started
node.connect(mgr)

Expand Down
Loading