Renamed WithAsyncSend() to WithNoSendWaiting()

relab · Feb 5, 2021 · f340ca8 · f340ca8
1 parent 017286e
commit f340ca8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/callopts.go b/callopts.go
@@ -18,9 +18,9 @@ func getCallOptions(callType *protoimpl.ExtensionInfo, opts []CallOption) callOp
 	return o
 }
 
-// WithAsyncSend is a CallOption that makes Unicast or Multicast methods
+// WithNoSendWaiting is a CallOption that makes Unicast or Multicast methods
 // return immediately instead of blocking until the message has been sent.
-func WithAsyncSend() CallOption {
+func WithNoSendWaiting() CallOption {
 	return func(o *callOptions) {
 		o.noSendWaiting = true
 	}

diff --git a/unicast_test.go b/unicast_test.go
@@ -21,7 +21,7 @@ func BenchmarkUnicast(b *testing.B) {
 	})
 	b.Run("UnicastAsyncSend/NewCall", func(b *testing.B) {
 		for i := 0; i < b.N; i++ {
-			unicastNewCall(context.Background(), cd, WithAsyncSend())
+			unicastNewCall(context.Background(), cd, WithNoSendWaiting())
 		}
 	})
 	b.Run("UnicastSyncSend/Basic", func(b *testing.B) {
@@ -31,7 +31,7 @@ func BenchmarkUnicast(b *testing.B) {
 	})
 	b.Run("UnicastAsyncSend/Basic", func(b *testing.B) {
 		for i := 0; i < b.N; i++ {
-			unicastBasic(context.Background(), cd, WithAsyncSend())
+			unicastBasic(context.Background(), cd, WithNoSendWaiting())
 		}
 	})
 }
@@ -43,7 +43,7 @@ func TestUnicast(t *testing.T) {
 	}
 	go consumeAndPutResult(cd.rq, cd.sendQ)
 	unicastBasic(context.Background(), cd)
-	unicastBasic(context.Background(), cd, WithAsyncSend())
+	unicastBasic(context.Background(), cd, WithNoSendWaiting())
 }
 
 type callData struct {