Merge pull request #190 from xuxiaofan1203/avoid-goroutine-leak

Fix goroutine leak when test with an empty node list
relab · Oct 10, 2024 · def9894 · def9894
2 parents e7ce532 + 3651439
commit def9894
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/channel_test.go b/channel_test.go
@@ -44,8 +44,9 @@ func TestChannelCreation(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
+	//the node should be closed manually because it isn't added to the configuration
+	defer node.close()
 	mgr := dummyMgr()
-	defer mgr.Close()
 	// a proper connection should NOT be established here
 	node.connect(mgr)
 
@@ -117,8 +118,9 @@ func TestChannelReconnection(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
+	//the node should be closed manually because it isn't added to the configuration
+	defer node.close()
 	mgr := dummyMgr()
-	defer mgr.Close()
 	// a proper connection should NOT be established here because server is not started
 	node.connect(mgr)