removed grpc.WithBlock method

relab · Jan 7, 2025 · a7ea2c7 · a7ea2c7
1 parent 3ac26b1
commit a7ea2c7
Show file tree

Hide file tree

Showing 14 changed files with 1 addition and 17 deletions.
diff --git a/channel_test.go b/channel_test.go
@@ -106,7 +106,7 @@ func TestChannelUnsuccessfulConnection(t *testing.T) {
 		t.Fatal("the node was not added to the configuration")
 	}
 	if node.conn == nil {
-		t.Fatal("connection should not be nil when NOT using WithBlock()")
+		t.Fatal("connection should not be nil")
 	}
 }
 

diff --git a/cmd/benchmark/main.go b/cmd/benchmark/main.go
@@ -191,7 +191,6 @@ func main() {
 
 	mgrOpts := []gorums.ManagerOption{
 		gorums.WithGrpcDialOptions(
-			grpc.WithBlock(),
 			grpc.WithTransportCredentials(insecure.NewCredentials()),
 		),
 		gorums.WithDialTimeout(10 * time.Second),

diff --git a/doc/user-guide.md b/doc/user-guide.md
@@ -231,7 +231,6 @@ func ExampleStorageClient() {
   mgr := NewManager(
     gorums.WithDialTimeout(500*time.Millisecond),
     gorums.WithGrpcDialOptions(
-      grpc.WithBlock(),
       grpc.WithTransportCredentials(insecure.NewCredentials()),
     ),
   )
@@ -406,7 +405,6 @@ func ExampleStorageClient() {
   mgr := NewManager(
     gorums.WithDialTimeout(50*time.Millisecond),
     gorums.WithGrpcDialOptions(
-      grpc.WithBlock(),
       grpc.WithTransportCredentials(insecure.NewCredentials()),
     ),
   )

diff --git a/examples/storage/client.go b/examples/storage/client.go
@@ -19,7 +19,6 @@ func runClient(addresses []string) {
 	mgr := proto.NewManager(
 		gorums.WithDialTimeout(1*time.Second),
 		gorums.WithGrpcDialOptions(
-			grpc.WithBlock(), // block until connections are made
 			grpc.WithTransportCredentials(insecure.NewCredentials()), // disable TLS
 		),
 	)

diff --git a/mgr_test.go b/mgr_test.go
@@ -75,7 +75,6 @@ func TestManagerAddNodeWithConn(t *testing.T) {
 	mgr := gorums.NewRawManager(
 		gorums.WithDialTimeout(100*time.Millisecond),
 		gorums.WithGrpcDialOptions(
-			grpc.WithBlock(),
 			grpc.WithTransportCredentials(insecure.NewCredentials()),
 		),
 	)

diff --git a/rpc_test.go b/rpc_test.go
@@ -107,7 +107,6 @@ func gorumsTestMgr() *dummy.Manager {
 	mgr := dummy.NewManager(
 		gorums.WithDialTimeout(time.Second),
 		gorums.WithGrpcDialOptions(
-			grpc.WithBlock(),
 			grpc.WithTransportCredentials(insecure.NewCredentials()),
 		),
 	)

diff --git a/server_test.go b/server_test.go
@@ -39,7 +39,6 @@ func TestServerCallback(t *testing.T) {
 		gorums.WithDialTimeout(time.Second),
 		gorums.WithMetadata(md),
 		gorums.WithGrpcDialOptions(
-			grpc.WithBlock(),
 			grpc.WithTransportCredentials(insecure.NewCredentials()),
 		),
 	)

diff --git a/tests/config/config_test.go b/tests/config/config_test.go
@@ -88,7 +88,6 @@ func TestConfig(t *testing.T) {
 	mgr := NewManager(
 		gorums.WithDialTimeout(100*time.Millisecond),
 		gorums.WithGrpcDialOptions(
-			grpc.WithBlock(),
 			grpc.WithTransportCredentials(insecure.NewCredentials()),
 		),
 	)

diff --git a/tests/correctable/correctable_test.go b/tests/correctable/correctable_test.go
@@ -25,7 +25,6 @@ func run(t *testing.T, n int, div int, corr func(context.Context, *Configuration
 	mgr := NewManager(
 		gorums.WithDialTimeout(time.Second),
 		gorums.WithGrpcDialOptions(
-			grpc.WithBlock(),
 			grpc.WithTransportCredentials(insecure.NewCredentials()),
 		),
 	)

diff --git a/tests/metadata/metadata_test.go b/tests/metadata/metadata_test.go
@@ -63,7 +63,6 @@ func TestMetadata(t *testing.T) {
 		gorums.WithMetadata(md),
 		gorums.WithDialTimeout(time.Second),
 		gorums.WithGrpcDialOptions(
-			grpc.WithBlock(),
 			grpc.WithTransportCredentials(insecure.NewCredentials()),
 		),
 	)
@@ -97,7 +96,6 @@ func TestPerNodeMetadata(t *testing.T) {
 		gorums.WithPerNodeMetadata(perNodeMD),
 		gorums.WithDialTimeout(time.Second),
 		gorums.WithGrpcDialOptions(
-			grpc.WithBlock(),
 			grpc.WithTransportCredentials(insecure.NewCredentials()),
 		),
 	)
@@ -125,7 +123,6 @@ func TestCanGetPeerInfo(t *testing.T) {
 	mgr := NewManager(
 		gorums.WithDialTimeout(time.Second),
 		gorums.WithGrpcDialOptions(
-			grpc.WithBlock(),
 			grpc.WithTransportCredentials(insecure.NewCredentials()),
 		),
 	)

diff --git a/tests/oneway/oneway_test.go b/tests/oneway/oneway_test.go
@@ -65,7 +65,6 @@ func setup(t testing.TB, cfgSize int) (cfg *oneway.Configuration, srvs []*oneway
 	mgr := oneway.NewManager(
 		gorums.WithDialTimeout(100*time.Millisecond),
 		gorums.WithGrpcDialOptions(
-			grpc.WithBlock(),
 			grpc.WithTransportCredentials(insecure.NewCredentials()),
 		),
 	)

diff --git a/tests/ordering/order_test.go b/tests/ordering/order_test.go
@@ -89,7 +89,6 @@ func setup(t *testing.T, cfgSize int) (cfg *Configuration, teardown func()) {
 	mgr := NewManager(
 		gorums.WithDialTimeout(100*time.Millisecond),
 		gorums.WithGrpcDialOptions(
-			grpc.WithBlock(),
 			grpc.WithTransportCredentials(insecure.NewCredentials()),
 		),
 	)

diff --git a/tests/tls/tls_test.go b/tests/tls/tls_test.go
@@ -49,7 +49,6 @@ func TestTLS(t *testing.T) {
 	mgr := NewManager(
 		gorums.WithDialTimeout(100*time.Millisecond),
 		gorums.WithGrpcDialOptions(
-			grpc.WithBlock(),
 			grpc.WithTransportCredentials(credentials.NewClientTLSFromCert(cp, "")),
 			grpc.WithReturnConnectionError(),
 		),

diff --git a/tests/unresponsive/unreponsive_test.go b/tests/unresponsive/unreponsive_test.go
@@ -31,7 +31,6 @@ func TestUnresponsive(t *testing.T) {
 	mgr := NewManager(
 		gorums.WithDialTimeout(100*time.Millisecond),
 		gorums.WithGrpcDialOptions(
-			grpc.WithBlock(),
 			grpc.WithTransportCredentials(insecure.NewCredentials()),
 		),
 	)