quit saving evaluate result as file #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keigohtr
reviewed
Apr 3, 2019
| option=result.option, | ||
| label=label_ios) | ||
| # TODO: deprecated. remove metrics from response in the next gRPC spec | ||
| metrics = rekcurd_pb2.EvaluationMetrics() |
There was a problem hiding this comment.
How do you get EvaluationMetrics at the beginning?
To save the evaluation result on dashboard, we need to get scores from Rekcurd.
There was a problem hiding this comment.
at the beginning, EvaluateModel method get & returns EvaluationMetrics to dashboard, and dashboard save the metrics.
This part is just to restore the result of EvaluateModel method.
There was a problem hiding this comment.
Do you mean we don't need to pack EvaluationMetrics to EvaluationResultResponse?
I see.
keigohtr
approved these changes
Apr 3, 2019
| option=result.option, | ||
| label=label_ios) | ||
| # TODO: deprecated. remove metrics from response in the next gRPC spec | ||
| metrics = rekcurd_pb2.EvaluationMetrics() |
There was a problem hiding this comment.
Do you mean we don't need to pack EvaluationMetrics to EvaluationResultResponse?
I see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
dashboard saves evaluation result to db (result column of evaluation_result table),
so not need to save as file
This PR includes
What type of PR is it?
fix
What is the issue?
#45
How should this be tested?
python -m unittest