fix(PagerFactory): pager should not be lazy, so that if the page do…

…es not exist, it will throw an exception immediately, not inside template. (#61)
rekalogika · Jun 8, 2024 · 8ed484f · 8ed484f
1 parent eab44de
commit 8ed484f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,8 @@
 # 0.9.2
 
 * build: limit `zenstruck/foundry` to 1.37.* for now
+* fix(`PagerFactory`): pager should not be lazy, so that if the page does not
+  exist, it will throw an exception immediately, not inside template.
 
 # 0.9.1
 

diff --git a/packages/rekapager-bundle/src/PagerFactory.php b/packages/rekapager-bundle/src/PagerFactory.php
@@ -96,7 +96,6 @@ public function createPager(
         $queryParams = $request->query->all();
         $routeParams = array_merge($queryParams, $routeParams);
 
-
         /** @var array<string,string|int> $routeParams */
 
         $pageUrlGenerator = $this->pageUrlGeneratorFactory->createPageUrlGenerator(
@@ -106,13 +105,17 @@ public function createPager(
             routeParams: $routeParams
         );
 
-        return new Pager(
+        $pager = new Pager(
             page: $page,
             proximity: $proximity,
             pageLimit: $pageLimit,
             pageUrlGenerator: $pageUrlGenerator,
             pageIdentifierEncoderLocator: $this->pageIdentifierEncoderLocator,
         );
+
+        foreach ($pager->getCurrentPage() as $i);
+
+        return $pager;
     }
 
     /**