prover: make sure response values have 0x and 0 padding #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix inconsistency in JSON response - make sure every number in the response is prefixed with "0x" if it's a hex. Make sure hex numbers are 0-padded to full bytes. E.g. instead of 0xaab return 0x0aab. This makes the response Solidity-friendly, as Solidity gets confused if hex numbers contain nibbles. Signed-off-by: Wojciech Zmuda <[email protected]>
When proving failed, error code was ignored, and null response was parsed and returned. Catch the error and return early. Signed-off-by: Wojciech Zmuda <[email protected]>
wzmuda
force-pushed
the
wz/response-nicer-hex
branch
from
8d230c7 to
2d91e93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix inconsistency in JSON response - make sure every number in the response is prefixed with "0x" if it's a hex.
Make sure hex numbers are 0-padded to full bytes. E.g. instead of 0xaab return 0x0aab. This makes the response Solidity-friendly, as Solidity gets confused if hex numbers contain nibbles.