Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make prover insertion response contract-friendly #19

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Make prover insertion response contract-friendly #19

merged 2 commits into from
Sep 9, 2024

Conversation

wzmuda
Copy link
Collaborator

@wzmuda wzmuda commented Sep 6, 2024 •
edited
Loading

Adjust the response as follows:

  • use SHA256 for prove generation. This affects the response indirectly - the proof is calculated differently and makes it into the response exactly the same as before, but now the proof's form is acceptable by Ethereum,
  • change the form of KZG proof and commitment from single 48B hex strings to an array of 3 16B hex strings, as this is the form expected by our contracts,

We've discovered the need for these changes when doing E2E testing with @cichaczem .

@wzmuda wzmuda force-pushed the wz/contracts-friendly-response branch from 42b377a to fc7b039 Compare September 6, 2024 18:32
@wzmuda
prover: insertion: hash bytes to field with sha256
bd54cf6 
This change is necessary for generating Ethereum-compatible proof.
Change the verifier accordingly, so the proof generated by smtb is
compatible with itself.

Signed-off-by: Wojciech Zmuda <[email protected]>
@wzmuda
prover: response: return KZG commitment and proof as arrays
2dc2168 
Contracts expect KZG values to be passed as arrays of 16-byte numbers.
Modify the response accordingly so these values are returned in that
form, instead of just single 48-byte-long values.

Signed-off-by: Wojciech Zmuda <[email protected]>
@wzmuda wzmuda force-pushed the wz/contracts-friendly-response branch from fc7b039 to 2dc2168 Compare September 9, 2024 18:08
@wzmuda wzmuda merged commit 55c29c9 into next Sep 9, 2024
1 check passed
@wzmuda wzmuda mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kustosz kustosz kustosz approved these changes

Assignees

@kustosz kustosz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wzmuda @kustosz