prover: verify: update verify
command to EIP-4844
#18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Prior to this change the following problem occurred
This is because the handler of the
verify
command did not took EIP-4844 changes into consideration. It still operated on the old insertion circuit structure. It compiled accidentally, because the new structure extends the old one. Theverify
handler still used valid field names of the circuit's structure, but didn't populate all of them. Therefore proof verification failed.Solution
gnark-mbu verify
was neglected in EIP-4844 changes. Update the VerifyInsertion handler, so that it uses the recent insertion circuit structure. Fields of the structure are populated both from:The new --params flag accepts input from
gnark-mbu gen-test-params
command.Dedicated --input-hash flag is not needed for the insertion mode, as input hash is included in the response. This flag was made optional and is checked in deletion only.
Demonstration
Prior
gnark-mbu setup
is implied.