Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR minimizes the usage of
import Mathlib
and replaces it with more targetedMathlib
importsI noticed some slow compilation issues (likely related to this Zulip thread) while I was going through and first getting familiar with the library structure, and this fixes it to a certain extent.
Some downsides of this:
import Mathlib
OfNat ((Fp p) × Unit) 5
which went through deducingCommRing Unit
inLampe.Builtin.Struct
was a surprising one.The only occurence of
import Mathlib
that remains is inLampe.lean
which has a bunch of examples. That rely onaesop
to function. Perhaps these examples could be moved to a separate example file, andLampe.lean
could be the root of the library for end-users to import?