Implement handling of function pointers #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
iamrecursion
force-pushed
the
wip/ara/function-pointer-impl
branch
4 times, most recently
from
6f0716d to
3114d7b
Compare
iamrecursion
force-pushed
the
wip/ara/function-pointer-impl
branch
from
3114d7b to
bd7a5b4
Compare
Eagle941
reviewed
Jan 18, 2025
Eagle941
reviewed
Jan 18, 2025
iamrecursion
force-pushed
the
wip/ara/name-mangling
branch
from
aeb3df3 to
9cea036
Compare
iamrecursion
force-pushed
the
wip/ara/function-pointer-impl
branch
2 times, most recently
from
f568279 to
919064b
Compare
ktemkin
reviewed
Jan 26, 2025
iamrecursion
force-pushed
the
wip/ara/name-mangling
branch
from
9cea036 to
8e16cbf
Compare
iamrecursion
force-pushed
the
wip/ara/function-pointer-impl
branch
2 times, most recently
from
dcc56eb to
7651b38
Compare
Function pointers are now handled according to the memory model documentation, ensuring that we can generate code that will allow us to call through opaque function pointers correctly. Note that this commit only encompasses the compiler-side part of this work, with more work to be done in the linker to handle generation of the meta-dispatch functions for each function type. It also makes some minor changes to the mangler to allow it to handle reserved names in a more sensible way. Closes #100
iamrecursion
force-pushed
the
wip/ara/function-pointer-impl
branch
from
7651b38 to
ccc4658
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Function pointers are now handled according to the memory model documentation, ensuring that we can generate code that will allow us to call through opaque function pointers correctly.
Note that this commit only encompasses the compiler-side part of this work, with more work to be done in the linker to handle generation of the meta-dispatch functions for each function type.
Closes #100
Details
Check that it seems sane please!
Checklist
scarb fmt.