docs: ALU: updates after recent contributions #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The second argument for smax, smin, umax, umin, scmp and ucmp was always i8, despite these LLVM intrinsics accept two arguments of the same type. Fix this mistake by making both arguments the same length for all of the aforementioned polyfills. Signed-off-by: Wojciech Zmuda <[email protected]>
While working on first ALU contributions we decided to implement polyfills for i128 types from the start[1]. Remove the (*) symbol from i128 polyfills. [1] #38 (comment) Signed-off-by: Wojciech Zmuda <[email protected]>
Signed-off-by: Wojciech Zmuda <[email protected]>
wzmuda
force-pushed
the
wz/alu-design-update
branch
from
8154208 to
e4c0544
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
Checklist
[ ] Code is formatted by Rustfmt orscarb fmt.