Pr/membership #190
Pr/membership #190
Conversation
src/styles/cdr-reset.scss
Outdated
| --cdr-color-border-surface-primary: #{$cdr-color-border-secondary}; | ||
| --cdr-color-border-surface-secondary: #726d64; | ||
| } | ||
|
|
There was a problem hiding this comment.
With this removal, how are users expected to add in palettes? Maybe they would need to import the palettes file manually?
There was a problem hiding this comment.
I think this question still applies—should we export the palette sass file you created?
There was a problem hiding this comment.
I ended up moving this file to styles root dir and allowing it to be built to dist
|
Overall looks good, just looking to clarify a few things |
| } | ||
|
|
||
| [data-palette='membership-subtle'] { | ||
| --cdr-color-background-surface-primary: var(--cdr-membership-subtle-color-background-primary); |
There was a problem hiding this comment.
If these get changed to sass variables, solves the double import issue perhaps
There was a problem hiding this comment.
yes I added sass as a fallback
| @@ -9,28 +9,72 @@ import { getSurfaceProps } from '../../utils/surface'; | |||
| defineOptions({ name: 'CdrSurface' }); | |||
|
|
|||
| const props = withDefaults(defineProps<surface>(), { | |||
| /** | |||
There was a problem hiding this comment.
FYI this type of documentation is also part of the surface interface type. I'm not sure which one the doc site will pick up. I could see it as a little confusing to have both for someone coming into it without background knowledge, but I don't mind.
There was a problem hiding this comment.
Oh my bad - interface seems like the correct location for this - the doc site seems to be using slightly different language
Description
membership palettes