Layout #187
Merged
Layout #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sikhote
commented
Nov 11, 2024
mhewson
approved these changes
Nov 14, 2024
src/styles/settings/index.scss
Outdated
| @@ -7,13 +7,42 @@ $cdr-warn: false; | |||
| @import './visibility.vars'; | |||
| @import './fluid.vars'; | |||
|
|
|||
| // Import fluid.vars.scss if using in a component | |||
There was a problem hiding this comment.
why are these directly in index I would expect that index only imports child files into a central index of containing files?
There was a problem hiding this comment.
Will do to break apart a bit more
There was a problem hiding this comment.
Broke this file apart a lot more
mhewson
reviewed
Nov 25, 2024
| @@ -0,0 +1,21 @@ | |||
| // Generates a background property with a predictable format for overriding | |||
There was a problem hiding this comment.
is this for kitchen sink demos?
There was a problem hiding this comment.
This gets used by the Surface component. For the overriding feature, that's more to allow the user an easy way to override, kinda like we do with cedar button's background and other styles. For the comment itself, it won't show up in the demo—sorry, not sure what you are asking exactly 😅
c4rlosviteri
approved these changes
Nov 25, 2024
mhewson
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo available here: https://rei.github.io/rei-cedar