Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sv_allowupload check on netchan validate #788

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add sv_allowupload check on netchan validate #788

wants to merge 2 commits into from

Conversation

SergeyShorokhov
Copy link
Member

@SergeyShorokhov SergeyShorokhov commented Oct 6, 2020 •
edited
Loading

fix #787

This solution helps, but, the implementation is bad and I am looking for a better solution.
I haven't found a better solution yet, because the engine protocol can't tell the client to stop the download request.

P.S: I leave this PR open, as it solves the problem, albeit in a crutch way.

Download

@SergeyShorokhov SergeyShorokhov changed the title Add CVar sv_allowupload check on netchat validate Add CVar sv_allowupload check on netchan validate Oct 6, 2020
@RauliTop
Copy link
Contributor

RauliTop commented Dec 3, 2020 •
edited
Loading

@s1lentq
when is it going to merge?

@stambeto2006
Copy link

@wopox1337 @s1lentq
When is this update officially expected to enter?

@theAsmodai
Copy link
Collaborator

It's absolutelly incorrect place to fix your issue.

@theAsmodai theAsmodai closed this Jan 27, 2021
@SergeyShorokhov
Copy link
Member Author

SergeyShorokhov commented Jan 29, 2021 •
edited
Loading

@theAsmodai agree with you, but any suggestions?

@RauliTop
Copy link
Contributor

RauliTop commented Feb 4, 2021

but please, @theAsmodai don't close the issue and forget about it.

We need a fix

@SergeyShorokhov SergeyShorokhov changed the title Add CVar sv_allowupload check on netchan validate Add sv_allowupload check on netchan validate Oct 7, 2021
@SergeyShorokhov SergeyShorokhov self-assigned this Oct 7, 2021
@SergeyShorokhov SergeyShorokhov added Engine: 📀 reHLDS Case refers to reHLDS engine. Priority: ⚠️ medium Medium priority tasks that should be addressed soon. Status: 🕹️ on hold Task temporarily on hold. Type: 🧬 bug in original HLDS An error that could not be fixed by ReHLDS. labels Oct 7, 2021
gmcsforce added a commit to gmcsforce/rehlds that referenced this pull request Nov 4, 2021
@gmcsforce
Add sv_allowupload check on netchan validate
6af4b66 
CREDITS: wopox1337
PR: rehlds#788
@s1lentq s1lentq force-pushed the master branch 2 times, most recently from 43df0ba to de3679f Compare September 20, 2023 14:00
@Giferns Giferns mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1lentq s1lentq Awaiting requested review from s1lentq

@theAsmodai theAsmodai Awaiting requested review from theAsmodai

Assignees

@SergeyShorokhov SergeyShorokhov

Labels
Engine: 📀 reHLDS Case refers to reHLDS engine. Priority: ⚠️ medium Medium priority tasks that should be addressed soon. Status: 🕹️ on hold Task temporarily on hold. Type: 🧬 bug in original HLDS An error that could not be fixed by ReHLDS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flood SV_ProcessFile: Unrequested decal
4 participants
@SergeyShorokhov @RauliTop @stambeto2006 @theAsmodai