Update docs. Update build.

Signed-off-by: regorxxx <[email protected]>
regorxxx · Mar 10, 2024 · 90cc076 · 90cc076
1 parent 3b85a96
commit 90cc076
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,7 @@
 * added 'supported color spaces' to documentation
 * minor improvements to documentation
 * fix wrong handling of RGB and RGBA arrays when constructing chroma color objects.
+* fix wrong handling of values outside scale domain due to internal Math.pow usage. See [Issue 331](https://github.com/gka/chroma.js/issues/331)
 
 ### 2.7.0
 * added `chroma.brewer.getPalettes()` to retrieve all available palettes (keys). [ColorBrewer](http://colorbrewer2.org/) schemes (scales) are divided into palettes according to their type

diff --git a/chroma.js b/chroma.js
@@ -2948,7 +2948,9 @@
                 t = tMapLightness(t);  // lightness correction
             }
 
-            if (_gamma !== 1) { t = pow$3(t, _gamma); }
+            if (t > 1) { t = 1; } // pow fails with negative bases, but values are always clamped to the extremes
+            else if (t < 0) { t = 0; }
+            else if (_gamma !== 1) { t = pow$3(t, _gamma); }
 
             t = _padding[0] + (t * (1 - _padding[0] - _padding[1]));
 

diff --git a/chroma.min.js b/chroma.min.js
diff --git a/docs/index.html b/docs/index.html
@@ -779,6 +779,7 @@ <h3 id="unreleased">unreleased</h3>
 <li>added &#39;supported color spaces&#39; to documentation</li>
 <li>minor improvements to documentation</li>
 <li>fix wrong handling of RGB and RGBA arrays when constructing chroma color objects.</li>
+<li>fix wrong handling of values outside scale domain. See <a href="https://github.com/gka/chroma.js/issues/331">Issue 331</a></li>
 </ul>
 <h3 id="270">2.7.0</h3>
 <ul>

diff --git a/docs/libs/chroma.js b/docs/libs/chroma.js
@@ -2948,7 +2948,9 @@
                 t = tMapLightness(t);  // lightness correction
             }
 
-            if (_gamma !== 1) { t = pow$3(t, _gamma); }
+            if (t > 1) { t = 1; } // pow fails with negative bases, but values are always clamped to the extremes
+            else if (t < 0) { t = 0; }
+            else if (_gamma !== 1) { t = pow$3(t, _gamma); }
 
             t = _padding[0] + (t * (1 - _padding[0] - _padding[1]));
 

diff --git a/docs/libs/chroma.min.js b/docs/libs/chroma.min.js