Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special workaround scripts to install #49

Merged

Conversation

kgilmer
Copy link
Member

@kgilmer kgilmer commented Feb 6, 2025

No description provided.

@kgilmer kgilmer requested a review from khos2ow February 6, 2025 02:29
Copy link
Member

@khos2ow khos2ow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the PR lgtm, except the comment below. We need to decide an approach.

debian/changelog Outdated
@@ -1,3 +1,10 @@
regolith-session (1.1.12-4) trixie; urgency=medium
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are dropping the support for force-overwrite on published repo, and as such this will cause an issue. What I think we should do is increment the last digit (i.e. 12 -> 13) and updated the last sufix (e.g. -4) to be an indicator for different "live branches". For example:

  • x.y.z-1: for main
  • x.y.z-2: for distro-foo
  • x.y.z-3: for distro-bar

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, setting to 1.1.13-2

@kgilmer kgilmer merged commit 21be803 into fix/trixie-session-init-1094494 Feb 9, 2025
2 checks passed
@kgilmer kgilmer deleted the fix/trixie-workaround-install branch February 9, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants