Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bbo/solo vs pool #21

Draft
wants to merge 3 commits into
base: hardhat/rewrite
Choose a base branch
from

Conversation

benjaminbours
Copy link

Screenshot 2024-11-23 at 17 34 08

The goal was to try to make it as easy as possible for users to understand the choice we offer to them. A pool or not a pool? How are they suppose to know? Technical users they will know of course, but maybe the random dude doesn't and he wants to mine.

I am not expecting this to ever be merged, definitely not a key feature and the layout / purpose is debatable, but it was good to experience this dioxus framework. I am familiar with React and I feel at home with this component base system, even if it's a bit frustrating and weird to write HTML that way.

This PR is still a WIP but any feedback would be appreciated.

For example, I have written a part with custom CSS because I am much faster than to go check tailwind doc for each classes. I also dislike deeply the readability of the HTML with tailwind and I prefer to use CSS naming convention such as BEM. So basically I am not respecting the project's conventions as soon as I arrive. How flexible are we here?

I also noticed a few things if I may.

  • Too much things are span in the HTML. HTML semantic is important for content indexation and SEO in general.
  • Trying to use tailwind, I realize in the tailwind.css file included in the project, it is missing some classes mentioned in the doc. In my case, I noticed w-1/2 is missing.
  • I had to go in the doc of dioxus to find the command to serve with hot reloading. Could be nice to have it documented in the README.

I could create issues for each of these points if I receive a positive confirmation that it could improve the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant