Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal was to try to make it as easy as possible for users to understand the choice we offer to them. A pool or not a pool? How are they suppose to know? Technical users they will know of course, but maybe the random dude doesn't and he wants to mine.
I am not expecting this to ever be merged, definitely not a key feature and the layout / purpose is debatable, but it was good to experience this dioxus framework. I am familiar with React and I feel at home with this component base system, even if it's a bit frustrating and weird to write HTML that way.
This PR is still a WIP but any feedback would be appreciated.
For example, I have written a part with custom CSS because I am much faster than to go check tailwind doc for each classes. I also dislike deeply the readability of the HTML with tailwind and I prefer to use CSS naming convention such as BEM. So basically I am not respecting the project's conventions as soon as I arrive. How flexible are we here?
I also noticed a few things if I may.
span
in the HTML. HTML semantic is important for content indexation and SEO in general.tailwind.css
file included in the project, it is missing some classes mentioned in the doc. In my case, I noticedw-1/2
is missing.I could create issues for each of these points if I receive a positive confirmation that it could improve the project.