Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequencing UB #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sequence-points/README
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The expectation is that without sequence points between read/writes C will evaluate in a left to right fashion. Also, each modification of a value will complete before the next use of that variable.
26 changes: 26 additions & 0 deletions sequence-points/p1.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
#include <stdio.h>
#include <stdlib.h>


/* comments say what the programmer would expect */

const int nums[32] = {1, 2, 3, 4, 5, 6, 7, 8,
9, 10, 11, 12, 13, 14,
15, 16, 17, 18, 19, 20,
21, 22, 23, 24, 25, 26,
27, 28, 29, 30, 31, 32 };

int main(void) {

int index = 0;

index = nums[index++]; //index = nums[0]; index++; -> index = 2;
index = nums[index++]; //index = nums[2]; index++; -> index = 4;
index = nums[index++]; //index = nums[4]; index++; -> index = 6;
index = nums[index++]; //index = nums[6]; index++; -> index = 8;
index = nums[index++]; //index = nums[8]; index++; -> index = 10;
index = nums[index++]; //index = nums[10]; index++; -> index = 12;
printf("index is %d\n", index);

return EXIT_SUCCESS;
}
1 change: 1 addition & 0 deletions sequence-points/p1.output
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
index is 12
19 changes: 19 additions & 0 deletions sequence-points/p2.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
#include <stdio.h>
#include <stdlib.h>

int main(void)
{

unsigned int x = 15;
unsigned int y = 25;
unsigned result = 0;

/* programmer assumes left to right evaluation,
even with unary ops mixed in */
/* 16 + 15 + (50 * 50) + 50 + 15 */
result = x = y = x++ + x-- + (y*=2 * y) + y + x ;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about your interpretation here (I tried multiple times to come up with a good example like this and also had a hard time). Can you refactor into simpler UBs such as i = i++?


printf("result %d\n", result );

return EXIT_SUCCESS;
}
1 change: 1 addition & 0 deletions sequence-points/p2.output
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
result 2596