Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: switch between plus/minis icon when expanding summary #16

Merged
merged 1 commit into from
Dec 9, 2023
Merged

feature: switch between plus/minis icon when expanding summary #16

merged 1 commit into from
Dec 9, 2023

Conversation

alexfauquette
Copy link
Collaborator

demo.mp4

aaadryyy
aaadryyy approved these changes Dec 9, 2023
View reviewed changes
Copy link
Collaborator

@aaadryyy aaadryyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool 👌
I saw you installed a matrial ui package for icons in a previous PR.
Are the icons the same as the ones used by David?
If yes we should not bother adding svg...

@alexfauquette
Copy link
Collaborator Author

alexfauquette commented Dec 9, 2023 •
edited
Loading

Are the icons the same as the ones used by David?

I think they are. Except if he used icons outside of material design.

I initially added an icon, because of the badge's dele icon which is not present in material icons

@alexfauquette alexfauquette merged commit be43206 into regardscitoyens:master Dec 9, 2023
1 check passed
@alexfauquette alexfauquette deleted the toggle-icon branch December 9, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-sanna-eki louis-sanna-eki louis-sanna-eki approved these changes

@aaadryyy aaadryyy aaadryyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexfauquette @aaadryyy @louis-sanna-eki