Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] Report all failed performance variables in FAILURE INFO #3358

Merged
merged 1 commit into from
Jan 14, 2025
Merged

[enhancement] Report all failed performance variables in FAILURE INFO #3358

merged 1 commit into from
Jan 14, 2025

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented Jan 10, 2025 •
edited
Loading

In case of a single failing performance variable the output doesn't change. If multiple are failing, this are listed in separate lines as follows:

  * Reason: performance error: failed to meet references:
	bw1=92 GB/s, expected 190 (l=180.5, u=199.5)
	bw2=58 GB/s, expected 190 (l=184.3, u=195.7)
	bw3=92 GB/s, expected 190 (l=186.2, u=193.8)

Closes #3357.

@vkarak vkarak added this to the ReFrame 4.8 milestone Jan 10, 2025
@vkarak vkarak requested review from ekouts and teojgo January 10, 2025 15:30
@vkarak vkarak self-assigned this Jan 10, 2025
@vkarak vkarak merged commit 3ee98eb into reframe-hpc:master Jan 14, 2025
36 checks passed
@vkarak vkarak deleted the enhancement/failure-info branch January 14, 2025 21:31
@vkarak vkarak linked an issue Jan 14, 2025 that may be closed by this pull request
List all failed performance variable in test's FAILURE INFO #3357
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekouts ekouts ekouts approved these changes

@teojgo teojgo Awaiting requested review from teojgo

Assignees

@vkarak vkarak

Labels
enhancement prio: normal
Projects
ReFrame Backlog
Status: Done
Milestone
ReFrame 4.8
Development

Successfully merging this pull request may close these issues.

List all failed performance variable in test's FAILURE INFO
2 participants
@vkarak @ekouts