Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Treat node name suffixes properly in abbreviated node lists #3027

Merged
merged 1 commit into from
Oct 24, 2023
Merged

[bugfix] Treat node name suffixes properly in abbreviated node lists #3027

merged 1 commit into from
Oct 24, 2023

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented Oct 23, 2023

Closes #3021.

@vkarak vkarak added this to the ReFrame 4.5 milestone Oct 23, 2023
@vkarak vkarak requested review from victorusu and teojgo October 23, 2023 21:35
@vkarak vkarak self-assigned this Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7dd781b) 86.70% compared to head (7477204) 86.71%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3027   +/-   ##
=======================================
  Coverage   86.70%   86.71%           
=======================================
  Files          61       61           
  Lines       11996    12002    +6     
=======================================
+ Hits        10401    10407    +6     
  Misses       1595     1595
Files Coverage Δ
reframe/utility/__init__.py 93.54% <100.00%> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vkarak vkarak changed the title [bugfix] Treat node name suffixes properly in nodelists [bugfix] Treat node name suffixes properly in abbreviated node lists Oct 24, 2023
@vkarak vkarak merged commit 64ab7c0 into reframe-hpc:master Oct 24, 2023
18 checks passed
@vkarak vkarak deleted the bugfix/nodelist-treat-suffixes branch October 24, 2023 13:04
@vkarak vkarak linked an issue Oct 24, 2023 that may be closed by this pull request
--distribute capture hostname in wrong way #3021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teojgo teojgo teojgo approved these changes

@victorusu victorusu Awaiting requested review from victorusu

Assignees

@vkarak vkarak

Labels
bugfix prio: normal
Projects
ReFrame Backlog
Status: Done
Milestone
ReFrame 4.5
Development

Successfully merging this pull request may close these issues.

--distribute capture hostname in wrong way
2 participants
@vkarak @teojgo