Update Interface #48
Merged
Update Interface #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielgtaylor This will definitely need a look from you, as these are some big changes. |
|
|
||
| ```javascript | ||
| var objectElement = new minim.ObjectElement({ foo: 'bar' }); | ||
| var value = objectElement.getValue('foo') // returns 'bar' |
There was a problem hiding this comment.
seems just objectElement.value(0) would be sufficient. As a rubyist my pull is to keep get and set out of method names, so I am biased.
There was a problem hiding this comment.
Added an issues to discuss this.
|
@fosrias I've addressed all comments. |
| expect(el.meta.class.toValue()).to.deep.equal(['a', 'b']); | ||
| expect(el.meta.title.toValue()).to.equal('Title'); | ||
| expect(el.meta.description.toValue()).to.equal('Description'); | ||
| expect(el.meta.get('id').toValue()).to.equal('foobar'); |
There was a problem hiding this comment.
So, I cannot do: el.meta.id.toValue() now? This seems extra verbose (shock me).
There was a problem hiding this comment.
You can do element.id, but currently not element.meta.id. It's the same interface now for any object with helper methods on element.
|
@smizell Fine by me. Leave to @danielgtaylor to clarify anything. |
kylef
pushed a commit
that referenced
this pull request
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does several things.
obj.set({ foo: 'bar' })to work for objectsgetValuemethod which is short forobj.get('foo').toValue(). Now you can doobj.getValue('foo').