add renderSumType to efficiently render sum types #115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is complete enough that we can figure out if/where it has a home upstream in reflex-dom.
See inline comment on renderSumType.
This function provides an alternative to two approaches to sum types
that already exist
using dyn/widgetHold. This approach has the downside that the Dynamic
is lost while rendering everything under the sum type, which means
that every change causes a full re-render.
rendering every constructor, and having a dynamic attribute with
'display:none' set for everything except the currently active
constructor. This works but is less principled - you are rendering
something that doesn't actually exist, and then hiding it, instead of
simply not rendering it in the first place (the approach of
renderSumType).