Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle bool cast for optional NumberVar #4010

Merged
merged 3 commits into from
Sep 27, 2024
+3 −0
Merged

Handle bool cast for optional NumberVar #4010

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
885a516
Handle bool cast for optional NumberVar
masenf Sep 26, 2024
3c3ff97
boolify the result of `and_operation`
masenf Sep 26, 2024
35abb16
flip order to be more semantically pure
adhami3310 Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions reflex/vars/number.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
from reflex.constants.base import Dirs
from reflex.utils.exceptions import PrimitiveUnserializableToJSON, VarTypeError
from reflex.utils.imports import ImportDict, ImportVar
from reflex.utils.types import is_optional

from .base import (
CustomVarOperationReturn,
Expand Down Expand Up @@ -524,6 +525,8 @@ def bool(self):
Returns:
The boolean value of the number.
"""
if is_optional(self._var_type):
return boolify((self != None) & (self != 0)) # noqa: E711
return self != 0

def _is_strict_float(self) -> bool:
Expand Down
Loading