Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Mantine): support mantine 7 #6345

Open
wants to merge 73 commits into
base: main
Choose a base branch
from
Open

Conversation

alodela
Copy link

@alodela alodela commented Sep 17, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

Support for Mantine 5

What is the new behaviour?

Continuing the work done in #5340 to support Mantine 7

Notes for reviewers

Notable problems:
Mantine 7 uses CSS modules for styling, and @refinedev/mantine uses tsup to build, which doesn't support css modules
egoist/tsup#536

Any input or feedback welcome

Mantine migration guides:
https://v6.mantine.dev/changelog/6-0-0/
https://mantine.dev/guides/6x-to-7x/

closes #5178

glebtv and others added 30 commits February 21, 2024 14:53
@BatuhanW
Copy link
Member

BatuhanW commented Nov 8, 2024

Hey @kruschid sorry for the late response, we've been busy through the week. We'll answer your comments next week.

@kruschid
Copy link

kruschid commented Nov 8, 2024

Hey @kruschid sorry for the late response, we've been busy through the week. We'll answer your comments next week.

That's okay, it's quite a large PR. I'm trying to upgrade my project to v7 using the changes here. I couldn't test every detail yet, but still wanted to contribute, at least by adding some comments. @glebtv and @alodela have done good work here 🚀 , and my comments are rather cosmetic. If I find more issues, I'll make further comments. Thank you. 👍

@BatuhanW
Copy link
Member

Hey @alodela Would you like to release Mantine 7 support as a standalone package on npm and your own repository? We'd be more than happy to update documentation and website, mention that Mantine 7 supported library is yours and add links to your package.

@alodela
Copy link
Author

alodela commented Nov 24, 2024

That's a generous offer, @BatuhanW, but I'm a bit worried about keeping the standalone Mantine package up and running in the long run since bandwidth can be an issue. What’s the thinking behind releasing Mantine support as a standalone package? I would love to hear your thoughts!

@aliemir
Copy link
Member

aliemir commented Nov 25, 2024

I'm hoping to deliver a detailed review of the PR very soon. Thank you for your work, @alodela! 🙌

For now and in the foreseeable future, our focus will primarily be on delivering new features and improvements to Refine's core. As a result, we find it challenging to keep up with major releases from external dependencies like Mantine.

However, we remain fully committed to supporting community-driven initiatives like this. If you decide to take ownership, we’ll promote the package alongside the ones we officially release and offer any help needed for maintenance and up-keeping.

Thanks again for your hard work and dedication. I'll post my review in following days 🙏

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for refine-doc-live-previews ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6bf3629
🔍 Latest deploy log https://app.netlify.com/sites/refine-doc-live-previews/deploys/67e330eeeeaaa200087a42d4
😎 Deploy Preview https://deploy-preview-6345--refine-doc-live-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alodela alodela requested a review from a team as a code owner December 30, 2024 08:19
@TheoD02
Copy link

TheoD02 commented Jan 10, 2025

Hey, how i can test this in existing project ?

The solution :

"@refinedev/mantine": "github:alodela/refine#path:packages/mantine&mantine7.v4",

Seem to not work on my side 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Mantine v7 support?
7 participants