Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bed12 recipe #1

Merged
merged 1 commit into from
Nov 30, 2022
Merged

add bed12 recipe #1

merged 1 commit into from
Nov 30, 2022

Conversation

mirpedrol
Copy link

@mirpedrol mirpedrol commented May 2, 2022

Add new recipe for bed12 and new asset class for bed file format as mentioned in #271.
Required on refgenie/aws_igenomes #1

@ewels
Copy link

ewels commented Jun 28, 2022

@nsheff - does this look good? I think this is the only thing remaining for us to get the RefGenie iGenomes on parity with AWS-iGenomes now.

@nsheff
Copy link
Contributor

nsheff commented Jun 30, 2022

Ok great -- I will finalize this very soon

@ewels
Copy link

ewels commented Nov 25, 2022

Hi @nsheff - anything we can do to move this PR along? 🙏🏻

inputs:
files:
bed:
description: Genomic feature annotations in Browser Extensible Data (BED12) format
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The input file is actually expected to be in gzipped bed format, right?

@nsheff nsheff merged commit 224509b into refgenie:master Nov 30, 2022
@nsheff
Copy link
Contributor

nsheff commented Nov 30, 2022

I updated the key to bedgz to reflect that you're actually wanting to store a gzipped bed file

@ewels
Copy link

ewels commented Nov 30, 2022

Nope, we've been using raw bed files - not compressed - until now (see path here for example).

But you're right, we should probably be using gzipped files. Means updating all of the code using these references but shouldn't be too difficult as long as we remember.

@nsheff
Copy link
Contributor

nsheff commented Dec 1, 2022

Ok -- I ask because the recipe was naming the file .bed.gz, so this wouldn't have worked with raw .bed files... well, they would have been bed files named blah.bed.gz...

@ewels
Copy link

ewels commented Dec 1, 2022

Oh I see 😅 Ok I'm sure it's fine, as long as @mirpedrol is on top of things 👍🏻

x-ref change here: 0bf4b6f

@mirpedrol
Copy link
Author

Thanks for the merge! 😄

@mirpedrol mirpedrol deleted the bed12 branch December 13, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants