Add support for custom config #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyomagma
changed the title
shleikes
suggested changes
Sep 22, 2024
src/constant.ts
Outdated
| indexerUrl: string | undefined = INDEXER_URL | ||
| ) { | ||
| indexerUrl: string | undefined = INDEXER_URL, | ||
| custom_config: Config | undefined = CONFIG |
src/constant.ts
Outdated
| @@ -10,12 +10,19 @@ export const FT_MINIMUM_STORAGE_BALANCE_LARGE = "12500000000000000000000" | |||
| export const ONE_YOCTO_NEAR = '0.000000000000000000000001'; | |||
| let ENV: string | undefined = ''; | |||
| let INDEXER_URL: string | undefined = ''; | |||
| let CONFIG: Config | undefined = undefined; | |||
There was a problem hiding this comment.
I thought it should be like the INDEXER_URL, changed.
There was a problem hiding this comment.
ok this is needed so it can get no value
added 2 commits
September 22, 2024 11:24
shleikes
suggested changes
Sep 22, 2024
src/constant.ts
Outdated
| @@ -1,4 +1,4 @@ | |||
| import { TokenMetadata } from './types'; | |||
| import { Config, TokenMetadata } from './types'; | |||
src/ref.ts
Outdated
| @@ -21,6 +21,7 @@ import { | |||
| TokenMetadata, | |||
| FTStorageBalance, | |||
| RefFiViewFunctionOptions, | |||
| Config, | |||
src/types.ts
Outdated
Comment on lines
142
to
153
|
|
||
| export type Config = { | ||
| networkId: string; | ||
| nodeUrl: string; | ||
| walletUrl: string; | ||
| WRAP_NEAR_CONTRACT_ID: string; | ||
| REF_FI_CONTRACT_ID: string; | ||
| REF_TOKEN_ID: string; | ||
| indexerUrl: string; | ||
| explorerUrl: string; | ||
| REF_DCL_SWAP_CONTRACT_ID: string; | ||
| }; |
| @@ -289,7 +288,7 @@ export const WalletSelectorTransactions = ( | |||
| }; | |||
| }); | |||
|
|
|||
| return { transactions: parsedTransactions } as SignAndSendTransactionsParams; | |||
| return { transactions: parsedTransactions }; | |||
| }; | |||
|
|
|||
There was a problem hiding this comment.
Module '"@near-wallet-selector/core/lib/wallet"' has no exported member 'SignAndSendTransactionsParams'.ts(2305)
It was deleted and I can't run npm install it with this line:
near/wallet-selector@65ea358#diff-cf1e42785f014c407e1c8f9672f2d13774005ebee6c4b8b65927b56e0f72ecb0L46
shleikes
approved these changes
Sep 23, 2024
| @@ -289,7 +288,7 @@ export const WalletSelectorTransactions = ( | |||
| }; | |||
| }); | |||
|
|
|||
| return { transactions: parsedTransactions } as SignAndSendTransactionsParams; | |||
| return { transactions: parsedTransactions }; | |||
| }; | |||
|
|
|||
|
GM @shleikes, can we have this functionality available anytime soon? I'm integrating Ref SDK into Potlock's funding stack and we already have our own multi-env configuration which I'd like to map to the SDK config |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.