refactor(asset): update ID methods and improve error handling in deco…

…mpression

asset/domain/entity/group.go

@@ -49,15 +49,15 @@ func (g *Group) Validate(ctx context.Context) validation.Result {
 	return validationCtx.Validate(ctx, fields)
 }
 
-// Getters
+// ID Getters
 func (g *Group) ID() id.GroupID       { return g.id }
 func (g *Group) Name() string         { return g.name }
 func (g *Group) Policy() string       { return g.policy }
 func (g *Group) Description() string  { return g.description }
 func (g *Group) CreatedAt() time.Time { return g.createdAt }
 func (g *Group) UpdatedAt() time.Time { return g.updatedAt }
 
-// Setters
+// UpdateName Setters
 func (g *Group) UpdateName(name string) error {
 	if name == "" {
 		return domain.ErrEmptyGroupName

asset/domain/errors.go

@@ -3,25 +3,25 @@ package domain
 import "errors"
 
 var (
-	// Asset errors
+	// ErrEmptyWorkspaceID Asset errors
 	ErrEmptyWorkspaceID = errors.New("workspace id is required")
 	ErrEmptyURL         = errors.New("url is required")
 	ErrEmptySize        = errors.New("size must be greater than 0")
 	ErrAssetNotFound    = errors.New("asset not found")
 	ErrInvalidAsset     = errors.New("invalid asset")
 
-	// Group errors
+	// ErrEmptyGroupName Group errors
 	ErrEmptyGroupName = errors.New("group name is required")
 	ErrEmptyPolicy    = errors.New("policy is required")
 	ErrGroupNotFound  = errors.New("group not found")
 	ErrInvalidGroup   = errors.New("invalid group")
 
-	// Storage errors
+	// ErrUploadFailed Storage errors
 	ErrUploadFailed   = errors.New("failed to upload asset")
 	ErrDownloadFailed = errors.New("failed to download asset")
 	ErrDeleteFailed   = errors.New("failed to delete asset")
 
-	// Extraction errors
+	// ErrExtractionFailed Extraction errors
 	ErrExtractionFailed = errors.New("failed to extract asset")
 	ErrNotExtractable   = errors.New("asset is not extractable")
 )

asset/domain/id/id.go

@@ -28,12 +28,12 @@ var (
 	MustProjectID   = idx.Must[idProject]
 	MustWorkspaceID = idx.Must[idWorkspace]
 
-	IDFrom          = idx.From[idAsset]
+	From            = idx.From[idAsset]
 	GroupIDFrom     = idx.From[idGroup]
 	ProjectIDFrom   = idx.From[idProject]
 	WorkspaceIDFrom = idx.From[idWorkspace]
 
-	IDFromRef          = idx.FromRef[idAsset]
+	FromRef            = idx.FromRef[idAsset]
 	GroupIDFromRef     = idx.FromRef[idGroup]
 	ProjectIDFromRef   = idx.FromRef[idProject]
 	WorkspaceIDFromRef = idx.FromRef[idWorkspace]

asset/infrastructure/decompress/zip.go

@@ -125,7 +125,12 @@ func (d *ZipDecompressor) CompressWithContent(ctx context.Context, files map[str
 
 		buf := new(bytes.Buffer)
 		zipWriter := zip.NewWriter(buf)
-		defer zipWriter.Close()
+		defer func(zipWriter *zip.Writer) {
+			err := zipWriter.Close()
+			if err != nil {
+				log.Warn("failed to close zip writer", zap.Error(err))
+			}
+		}(zipWriter)
 
 		// Use a mutex to protect concurrent writes to the zip writer
 		var mu sync.Mutex

asset/infrastructure/gcs/client.go

@@ -137,7 +137,7 @@ func (c *Client) List(ctx context.Context) ([]*entity.Asset, error) {
 			return nil, fmt.Errorf("%w: %v", ErrFailedToListAssets, err)
 		}
 
-		id, err := id.IDFrom(path.Base(attrs.Name))
+		id, err := id.From(path.Base(attrs.Name))
 		if err != nil {
 			continue // skip invalid IDs
 		}
@@ -262,7 +262,7 @@ func (c *Client) GetIDFromURL(urlStr string) (id.ID, error) {
 	urlPath = strings.TrimPrefix(urlPath, c.basePath)
 	urlPath = strings.TrimPrefix(urlPath, "/")
 
-	return id.IDFrom(urlPath)
+	return id.From(urlPath)
 }
 
 func (c *Client) getObject(id id.ID) *storage.ObjectHandle {
@@ -293,7 +293,7 @@ func (c *Client) FindByGroup(ctx context.Context, groupID id.GroupID) ([]*entity
 			return nil, fmt.Errorf("%w: %v", ErrFailedToListAssets, err)
 		}
 
-		assetID, err := id.IDFrom(path.Base(attrs.Name))
+		assetID, err := id.From(path.Base(attrs.Name))
 		if err != nil {
 			continue // skip invalid IDs
 		}

asset/infrastructure/gcs/client_test.go

@@ -243,7 +243,7 @@ func (c *testClient) Move(ctx context.Context, fromID, toID id.ID) error {
 func (c *testClient) List(ctx context.Context) ([]*entity.Asset, error) {
 	var assets []*entity.Asset
 	for _, obj := range c.mockBucket.objects {
-		id, err := id.IDFrom(path.Base(obj.name))
+		id, err := id.From(path.Base(obj.name))
 		if err != nil {
 			continue
 		}