-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docusaurus to v3 #4774
Update Docusaurus to v3 #4774
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2ad8d1a:
|
size-limit report 📦
|
166cfa7
to
4b0590c
Compare
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5cceac0
to
85eeb31
Compare
Looks like the TS/JS tabs are pretty broken, and in fact it's nuking all the code snippets. That's going to take some investigating. |
I am wondering if it is worth merging / deploying this even if the TS/JS toggles aren't working, simply because this does resolve a multitude of other issues. Obviously up to the team, though 🤷♂️ |
@rcherny unfortunately it turns out that the current changes actually delete all of the code snippets entirely. Which is... bad :) It's something about the Markdown + TS compilation plugin, but I don't know what yet. |
0e2404a
to
0c972fa
Compare
0c972fa
to
2ad8d1a
Compare
After a lot more investigation, I found that:
I briefly tried converting the transformation logic to await those nested promises and struggled. So, I converted the Prettier logic to use We've published that as |
This PR:
Fixes #4766
Fixes #4767
Status
This was a rather painful last 8 hours. Recapping:
remark-ts-tools
plugin compiling our snippets/@types/
folders in the rootnode_modules_
, and loading source file contents. over and over and over.remark-ts-tools
, for module resolution and file contents. Once I finally got it cooperating, RSPack builds with TS compilation are down to ~90sremark-ts-tools
and hopefully we can get that merged and published shortly