Preventing retries should result in the same result structure as if the retry wasn't used. #4721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, by forcing the value of `HandledError` to be of type `{error: any}` instead of the full result value, the meta field would be lost. This means there would be no way to fail out of retrying but keep the result consistent as if no retry had happened.
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fa36b6c:
|
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This would be a breaking change, yes - as the docs show, the fail utility only expects to be passed the error itself, not the entire result shape. You could make it non-breaking by changing it back and moving meta to a second parameter: |
|
Opted for #4723 instead, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3789. Originally, by forcing the value of
HandledErrorto be of type{error: any}instead of the full result value, the meta field would be lost. This means there would be no way to fail out of retrying but keep the result consistent as if no retry had happened.This PR fixes what I believe to be a bug, but could be a breaking change. Alternatives could be to add an additional fail option such as
failResult, or by exporting theHandledErrorclass to be manually thrown in whatever fashion the user desires.