Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default field to exports in package.json for better compatibility #400

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

Thiry1
Copy link
Contributor

@Thiry1 Thiry1 commented Jul 16, 2024

Add default field to exports in package.json for better compatibility.
Jest will be able to load the module and execute the transform.
fix #399
fix #390

Comment on lines 19 to 24
"exports": {
".": {
"import": "./dist/redux-actions.js"
"import": "./dist/redux-actions.js",
"default": "./dist/redux-actions.js"
}
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, the following configuration also worked well

{
  "exports": "./dist/redux-actions.js"
}

@Thiry1
Copy link
Contributor Author

Thiry1 commented Jul 17, 2024

@alexander-heimbuch Could you please take a moment to review it?

@alexander-heimbuch alexander-heimbuch merged commit 4dc05af into redux-utilities:master Jul 17, 2024
1 check passed
@Thiry1 Thiry1 deleted the default-export branch July 18, 2024 01:55
@kaelig
Copy link

kaelig commented Jul 18, 2024

Thank you! 👍🏻

@Thiry1
Copy link
Contributor Author

Thiry1 commented Jul 18, 2024

@alexander-heimbuch Thank you for merging. If possible, could you also publish it?

@alexander-heimbuch
Copy link
Contributor

Later today :)

@alexander-heimbuch
Copy link
Contributor

Fix is released in 3.03

@Thiry1
Copy link
Contributor Author

Thiry1 commented Jul 22, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working with Jest from v3.0.0 v3.0.0 + TypeScript Cannot find module 'redux-actions' from ...
3 participants