config: add cluster configuration validation to redpanda preload process
#25123
+279
−179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this related to #24987 ? |
…storage` To be able to use it in the `configuration` library (otherwise, a circular dependency is formed in the bazel BUILD).
WillemKauf
force-pushed
the
config_bootstrap_check
branch
from
e6a597d to
66d3360
Compare
Yes, it is the idea I presented in my comment here: #24987 (comment) |
WillemKauf
commented
Feb 20, 2025
src/v/config/configuration.h
Outdated
| @@ -772,4 +772,31 @@ bool development_feature_property<T>::development_features_enabled( | |||
|
|
|||
| configuration& shard_local_cfg(); | |||
|
|
|||
| // TODO: Move to anonymous namespace | |||
There was a problem hiding this comment.
This TODO is addressed in the later commit here: 116cb04
CI test resultstest results on build#62074
test results on build#62110
|
|
Requesting a review from an enterprise member as well 👍 |
oleiman
previously approved these changes
Feb 21, 2025
Moves the existing multi-property validation portion of the function from `admin/server.cc` into `config::configuration` as a static member function. The rest of the existing function which validate schema registry and admin endpoint users is left in `admin/server.cc`. This encapsulates the logic better, and also allows it to be re-used in other parts of the code which need to perform validation on cluster configs. Also, change in/out `std::map` parameters to a return struct, containing a `set` of properties that need to be unset in case of a bad configuration, as well as the `map` of properties and their corresponding errors.
To reject invalid configurations at start-up.
WillemKauf
force-pushed
the
config_bootstrap_check
branch
from
66d3360 to
5313abb
Compare
|
Force push to:
|
oleiman
approved these changes
Feb 21, 2025
I'm still learning people's preferences on how commits should be split up 😅 will see if any other reviewers feel the same and I can edit the history from there. |
all good. totally your call at the end of the day 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to idea here: #24987 (comment)
There existed a
config_multi_property_validation()function inadmin/server.cc, the purpose of which was to validatethe cluster config AFTER all updates made via the admin endpoint had been applied.
The other location where changes to the cluster config can be made is externally, in the
config_cache.yamlfile.If a user were to modify this file with an invalid (per the rules of
config_multi_property_validation()) configuration, it would not be caught until the next time the config was edited via the admin endpoint.This PR moves
config_multi_property_validation()into the static member functionconfig::configuration::validate_config(). It is still used inadmin/server.cc, but now it is also used inconfig/config_manager.ccto validate the cluster config set in the preload process.If any invalid properties are set, they are reset to their default values at start-up.
Backports Required
Release Notes
Improvements
redpandacluster configs by checking them at start-up.