storage
: break
, not co_return
, in adjacent_merge_compact()
#25119
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the purpose of making forward progress with adjacent merge compaction, we should not need to self compact every segment in the log before attempting adjacent compaction.
Change this
co_return
to abreak
to attempt adjacent merge compaction after self compacting a single segment.Tagged for backports.
Backports Required
Release Notes
Improvements
log_compaction_use_sliding_window
is disabled.