Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iceberg: make snapshot expiration an explicit 64-bit #25118

Merged
merged 1 commit into from
Feb 19, 2025
Merged

iceberg: make snapshot expiration an explicit 64-bit #25118

merged 1 commit into from
Feb 19, 2025
+5 −5

Conversation

andrwng
Copy link
Contributor

@andrwng andrwng commented Feb 19, 2025

Longs in Iceberg are 64-bit, so we should be explicit about that.

Review follow-up from
#25038

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@andrwng
iceberg: make snapshot expiration an explicit 64-bit
3765afd 
Longs in Iceberg are 64-bit, so we should be explicit about that.

Review follow-up from
redpanda-data#25038
@andrwng andrwng mentioned this pull request Feb 19, 2025
Merged
7 tasks
@andrwng andrwng enabled auto-merge February 19, 2025 20:23
@vbotbuildovich
Copy link
Collaborator

CI test results

test results on build#62034
test_id test_kind job_url test_status passed
rptest.tests.log_compaction_test.LogCompactionTest.compaction_stress_test.cleanup_policy=compact.key_set_cardinality=1000.storage_compaction_key_map_memory_kb=3 ducktape https://buildkite.com/redpanda/redpanda/builds/62034#0195200f-7440-48b1-b547-d0c952268962 FLAKY 1/2
rptest.tests.partition_balancer_test.PartitionBalancerTest.test_rack_awareness ducktape https://buildkite.com/redpanda/redpanda/builds/62034#0195200f-7440-48b1-b547-d0c952268962 FLAKY 1/2

@andrwng andrwng merged commit 8df894d into redpanda-data:dev Feb 19, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvartolomei nvartolomei nvartolomei approved these changes

@rockwotj rockwotj rockwotj approved these changes

@dotnwat dotnwat Awaiting requested review from dotnwat

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrwng @vbotbuildovich @nvartolomei @rockwotj