rptest/simple_connect_test: refactor out mount/unmount tests #25036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a method to make an RPCN counter stream config. Such a stream was already used in a couple places, and the configuration is quite a mouthful to write.
It's nice for test authors to not have to think about writing schema files, so this encapsulates some logic I found in simple_connect_test to create a schema using a tempfile.
Refactors simple_connect_test, pulling out the mount/unmount tests into a separate file, and updating both test files to use new reusable primitives for setting up RPCN and schemas. I also tweaked the structure to move setup to init/setUp methods and to avoid the test-body-as-lambdas pattern, since I found them a bit unnatural to read through. There are no major functional changes to the tests. I wanted to separate these tests because I intend on adding additional tests for mount/unmount functionality.
andrwng
commented
Feb 5, 2025
| self.wait_for_migration_states(out_migration_id, ['finished']) | ||
| self.wait_partitions_disappear([self.TOPIC_NAME]) | ||
|
|
||
| verifier.wait(progress_timeout_sec=10 * self.SLOW_COMMIT_INTVL_S) |
There was a problem hiding this comment.
@bashtanov on my local machine, this test ran for 12 minutes. I don't believe this is a result of my changes here -- is this call to verifier.wait(10min) actually what you want? It appears to be waiting that long, and it doesn't throw on timeout.
There was a problem hiding this comment.
FWIW 12 minute runs seem to be common recently for this test https://buildkite.com/organizations/redpanda/analytics/suites/redpanda-1/tests?branch=dev&period=7days&query=simple_connect_test&commit=Search
CI test resultstest results on build#61595
|
bashtanov
approved these changes
Feb 5, 2025
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports Required
Release Notes