pandaproxy/sr: bazelize compatibility_protobuf test #24657
Merged
+92
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IoannisRP
force-pushed
the
ik-bazel-tests-pandaproxy-p2
branch
5 times, most recently
from
215d783 to
e7a8052
Compare
IoannisRP
force-pushed
the
ik-bazel-tests-pandaproxy-p2
branch
from
e7a8052 to
e40d475
Compare
IoannisRP
requested review from
twmb,
r-vasquez,
gene-redpanda and
Deflaimun
as code owners
BenPope
reviewed
Jan 10, 2025
There was a problem hiding this comment.
I wonder if it's worth moving the well-known types from pandaproxy/BUILD to schema_registry/protobuf, as well?
Or maybe into /src/v/schema/protobuf?
I tried to package up confluent_proto, google_type_proto, and well_known_proto into their own cc_libraries, but failed to get that to work.
CI test resultstest results on build#60587
test results on build#60624
|
rockwotj
reviewed
Jan 10, 2025
Don't depend on the protobuf library, then to get raw `.proto` files you have to know about how the `proto_library` rule works, instead just create a filegroup rule for the protos that the go test depends on, which is also consumed by the `proto_library` rule.
rockwotj
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: CORE-7549 -
compatibility_protobuf.ccHad to change how the known types
.protofiles are ingested. Without the changes in theschema_registry_protosbazel target, they were visible using the full local path from workspace. i.e.Backports Required
Release Notes