datalake: remove offset translation from translation_stm (and add compaction_test.py)
#24610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillemKauf
force-pushed
the
datalake_translator_offset_fix
branch
from
5db3f18 to
6c113d7
Compare
WillemKauf
commented
Dec 18, 2024
| @@ -24,22 +24,24 @@ | |||
|
|
|||
| class DatalakeVerifier(): | |||
| """ | |||
| Verifier that does the verification of the data in the redpanda Iceberg table. | |||
| The verifier consumes offsets from specified topic and verifies it the data | |||
| Verifier that does the verification of the data in the redpanda Iceberg table. | |||
There was a problem hiding this comment.
Trailing whitespace removal
Retry command for Build#59935please wait until all jobs are finished before running the slash command |
CI test resultstest results on build#59935
test results on build#60023
test results on build#60079
|
|
Lot of Not sure if this is another The only related change I can see in EDIT: Probably just because of the |
WillemKauf
force-pushed
the
datalake_translator_offset_fix
branch
from
6c113d7 to
0e1a24c
Compare
|
Force push to:
|
WillemKauf
force-pushed
the
datalake_translator_offset_fix
branch
from
0e1a24c to
2fe6c55
Compare
Retry command for Build#60016please wait until all jobs are finished before running the slash command |
WillemKauf
force-pushed
the
datalake_translator_offset_fix
branch
from
2fe6c55 to
b01095c
Compare
|
Force push to:
|
| b.add_batch(std::move(batch)).get(); | ||
| }; | ||
|
|
||
| make_and_add_record(model::record_batch_type::raft_data); |
There was a problem hiding this comment.
i think it would make sense to add a test case where we start from configuration batch as this is what it looks like in real life, configuration is always the first batch
There was a problem hiding this comment.
Thanks for the callout here, I have added two new test cases which begin with configuration batches to translated_log_offset_test.
And most importantly, add the function `get_translated_log_offset()`. This function will be used to compute the appropriate highest translated log offset for a given translated kafka offset while taking into account translator batches. This is an important function for removing offset translation from within the `translation_stm`, and to be less pessimistic about the `max_collectible_offset` returned by the `stm` in the future.
Make use of the added utility function `get_translated_log_offset()` throughout `partition_translator.cc` and `state_machine.cc` in order to update the `translation_stm::_highest_translated_log_offset` as translation occurs. `translation_stm::max_collectible_offset()` now returns the `_highest_translated_log_offset` instead of performing offset translation for the `highest_translated_offset`, which is currently more restrictive than it should be for housekeeping (due to it being translator batch unaware).
By handling gaps in offsets and recording seen keys, we can validate the correctness of a compacted log that has been translated (fully) into an iceberg table.
Adds a new `test_compaction` test, which uses the `KgoVerifierSeqConsumer` to validate a fully compacted log, along with the `datalake_verifier` service to validate the Iceberg table. Also moves the contents of `compaction_gaps_test.py` into `compaction_test.py`.
WillemKauf
force-pushed
the
datalake_translator_offset_fix
branch
from
b01095c to
4bd7693
Compare
|
Force push to:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
datalake::translation::translation_stmwould return its max collectible as the following:redpanda/src/v/datalake/translation/state_machine.cc
Lines 112 to 122 in 925707c
This offset translation leads to an overly restrictive condition for the max collectible offset, due to the fact that it is translation batch unaware.
Here, the utility function
get_translated_log_offset()is added, which returns the "equivalent" translated log offset for a given kafka offset, taking into account translation batches (which don't need to be translated, and thus shouldn't restrict the max collectible offset).Use of this function is plumbed through the
partition_translatorand thetranslation_stm, and we now bookkeep the_highest_translated_log_offsetin thetranslation_stmto avoid any offset translation within it.Additionally, a new test for compaction with an Iceberg enabled topic is added to
datalake/compaction_test.py, with some enhancements to thedatalake_verifierservice to make it compaction aware.Backports Required
Release Notes
Improvements