iceberg: miscellaneous changes, copy methods #23394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missing, but it's a required field.
When operating on table metadata, it'll be handy to make copies of the schema to pass around, e.g. for serialization. To that end, this adds copy methods for types.
Implements a struct copy method used for schema copies, as this will be useful for serializating metadata by const ref. Swaps out the identifier fields container for one that is default copyable.
Similar to the recent copy metods for schemas, partition specs will also be serialized. It'd be convenient for serialization to have a copy method, so serialization doesn't necessarily need to move the spec.
dotnwat
approved these changes
Sep 20, 2024
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/54782#01920d07-c4fa-435e-8631-b9a09acfb6cf ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/54782#01920e09-5ef3-436a-8a50-9328b0bde136 |
abhijat
reviewed
Sep 20, 2024
abhijat
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some miscellaneous small changes, and a few copy methods (types, schema, partition_spec) that will be helpful in building metadata.
Backports Required
Release Notes