[CORE-8760] rptest: fix race-y checks in test_index_recovery_after_upgrade
#25131
+29
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI test resultstest results on build#62107
test results on build#62115
test results on build#62124
|
|
Still flakey. Hmm. |
WillemKauf
force-pushed
the
compaction_recovery_upgrade_test_fix
branch
from
ad6debc to
ef46591
Compare
This test can race with segment rolls and un-self-compacted segments, since self compaction may not occur before `redpanda` version changes and node restarts occur. Thus, breaking the expectations around the compacted index `mtime()` stats. To fix the race conditions, return the `partition` data used to evaluate compaction as being finished, and use that to perform the equality/inequality checks between compacted index `mtime()` values. Also ensure that all segements present in the `partition` data that are produced during a version epoch are self-compacted in that same epoch, per expectations of the test.
WillemKauf
force-pushed
the
compaction_recovery_upgrade_test_fix
branch
from
ef46591 to
854b56a
Compare
|
Force push to:
|
|
/ci-repeat 2 |
|
Still flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test can race with segment rolls and un-self-compacted segments, since self compaction may not occur before
redpandaversion changes and node restarts occur. Thus, breaking the expectations around the compacted indexmtime()stats.To fix the race conditions, return the
partitiondata used to evaluate compaction as being finished, and use that to perform the equality/inequality checks between compacted indexmtime()values.Also ensure that all segements present in the
partitiondata that are produced during a version epoch are self-compacted in that same epoch, per expectations of the test.Backports Required
Release Notes