Skip to content

Commit

Permalink
Merge pull request #23627 from vbotbuildovich/backport-pr-23339-v24.2…
Browse files Browse the repository at this point in the history
….x-720

[v24.2.x] Remove shard aggregation on consumer group metrics
  • Loading branch information
piyushredpanda authored Nov 7, 2024
2 parents 6634610 + 8dab9d1 commit 893f70f
Showing 1 changed file with 6 additions and 9 deletions.
15 changes: 6 additions & 9 deletions src/v/kafka/group_probe.h
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,10 @@ class group_offset_probe {
_public_metrics.add_group(
prometheus_sanitize::metrics_name("kafka:consumer:group"),
{sm::make_gauge(
"committed_offset",
[this] { return _offset; },
sm::description("Consumer group committed offset"),
labels)
.aggregate({sm::shard_label})});
"committed_offset",
[this] { return _offset; },
sm::description("Consumer group committed offset"),
labels)});
}

private:
Expand Down Expand Up @@ -130,15 +129,13 @@ class group_probe {
"consumers",
[this] { return _members.size(); },
sm::description("Number of consumers in a group"),
labels)
.aggregate({sm::shard_label}),
labels),

sm::make_gauge(
"topics",
[this] { return _offsets.size(); },
sm::description("Number of topics in a group"),
labels)
.aggregate({sm::shard_label})});
labels)});
}

private:
Expand Down

0 comments on commit 893f70f

Please sign in to comment.