Skip to content

Commit

Permalink
r/buffered_protocol: disable buffering in raft buffered protocol
Browse files Browse the repository at this point in the history
Changed the default value of a buffer size in raft buffered protocol to
disable the buffering completely. With the buffer enabled backpressure
from the followers wasn't propagated leading to a large queue of
requests waiting in the buffer. This made the replicate batcher to batch
far less effectively leading to increased latency and overall worse
performance.

We may reconsider enabling the buffer back if we implement different
batching strategy (a timer based) than batching only if backpressure is
propagated.

Signed-off-by: Michał Maślanka <[email protected]>
  • Loading branch information
mmaslankaprv committed Jan 24, 2025
1 parent b5e940d commit 6a3eddb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/v/config/configuration.cc
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ configuration::configuration()
"cannot change. When the total size of cached requests reaches the set "
"limit, back pressure is applied to throttle producers.",
{.needs_restart = needs_restart::no, .visibility = visibility::tunable},
512_KiB,
0,
{.min = 0, .max = 100_MiB})
, enable_usage(
*this,
Expand Down

0 comments on commit 6a3eddb

Please sign in to comment.