redpanda: simplify setting redpanda resources #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisseto
changed the title
|
This is a mirror/rebase of redpanda-data/helm-charts#1622 as the operator is now the host of the charts. |
This commit has no user facing changes. It refactors the various functions that affect and define the redpanda container's resources and the resource related CLI flags (`--smp`, `--memory`, `--reserve-memory`, and `--overprovisioned`) into methods on the `RedpandaResource` struct.
Prior to this commit it was not possible to "mix and match" the resource requests and limits of the redpanda container. The redpanda chart also required users to grok a new model of resources unique to the chart which made the chart less user friendly. This commit introduces a more user friendly and backwards compatible way of directly controlling the requests and limits of the redpanda container. Rather than directly exposing the `--smp`, `--memory`, `--reserve-memory`, and `--overprovisioned` flags to the end user, this method will infer them from the provided values with updated best practices. redpanda-data/helm-charts#1494 K8S-325 K8S-434
chrisseto
force-pushed
the
chris/p/redpanda-direct-resources
branch
from
35492dc to
1e8fa75
Compare
|
This branch needs to be rebased |
| @@ -346,7 +346,7 @@ data: | |||
| port: 33145 | |||
| rpk: | |||
| additional_start_flags: | |||
| - --default-log-level=info | |||
| - '----default-log-level=info' | |||
There was a problem hiding this comment.
why this has 4 dashes?
RafalKorepta
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on:
changiefor CHANGELOG.md management #374 (Can be removed, just wanted to test/showcase)MustRegexSplit#3738ddd726 redpanda: refactor resource flag computations
This commit has no user facing changes. It refactors the various functions that
affect and define the redpanda container's resources and the resource related
CLI flags (
--smp,--memory,--reserve-memory, and--overprovisioned)into methods on the
RedpandaResourcestruct.35492dc redpanda: simplify setting redpanda resources
Prior to this commit it was not possible to "mix and match" the resource
requests and limits of the redpanda container. The redpanda chart also required
users to grok a new model of resources unique to the chart which made the chart
less user friendly.
This commit introduces a more user friendly and backwards compatible way of
directly controlling the requests and limits of the redpanda container. Rather
than directly exposing the
--smp,--memory,--reserve-memory, and--overprovisionedflags to the end user, this method will infer them from theprovided values with updated best practices.
redpanda-data/helm-charts#1494
K8S-325
K8S-434